Use simple size-limit adapter #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1408 +/- ##
=======================================
Coverage 58.12% 58.12%
=======================================
Files 131 131
Lines 2909 2909
Branches 699 699
=======================================
Hits 1691 1691
Misses 1214 1214
Partials 4 4 Continue to review full report at Codecov.
|
size-limit report 📦
|
Mavrin
previously approved these changes
Jul 11, 2022
umputun
previously approved these changes
Jul 11, 2022
akellbl4
force-pushed
the
switch-to-pnpm
branch
3 times, most recently
from
09be685
to
1cab9b0
Compare
akellbl4
force-pushed
the
use-simple-size-adapter
branch
from
b44b4d1
to
a558b5e
Compare
Mavrin
previously approved these changes
Jul 12, 2022
|
conflicts |
umputun
previously approved these changes
Jul 12, 2022
akellbl4
force-pushed
the
use-simple-size-adapter
branch
from
a558b5e
to
71cddaa
Compare
akellbl4
force-pushed
the
use-simple-size-adapter
branch
from
71cddaa
to
571df25
Compare
|
@umputun can be merged |
Mavrin
approved these changes
Jul 12, 2022
umputun
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be merged only after #1404
Move back to
@size-limit/filebecause@size-limit/appis not that useful and creates more noise than helps with understanding if bundle size is increased.