Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean testid in production build #1331

Merged
merged 1 commit into from
Apr 15, 2022
Merged

clean testid in production build #1331

merged 1 commit into from
Apr 15, 2022

Conversation

akellbl4
Copy link
Collaborator

remove testid attribute from elements when build for production

@akellbl4 akellbl4 requested a review from Mavrin April 14, 2022 02:49
@akellbl4 akellbl4 requested a review from umputun as a code owner April 14, 2022 02:49
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1331 (3b309d4) into master (c58e647) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files         139      139           
  Lines        3046     3046           
  Branches      692      692           
=======================================
  Hits         1541     1541           
  Misses       1490     1490           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58e647...3b309d4. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 233 ms (-47.27% 🔽) 274 ms
public/remark.mjs 65.77 KB (-0.06% 🔽) 1.4 s (-0.06% 🔽) 895 ms (-1.75% 🔽) 2.3 s
public/remark.css 8.29 KB (-0.02% 🔽) 166 ms (-0.02% 🔽) 0 ms (+100% 🔺) 166 ms
public/last-comments.mjs 31.79 KB (0%) 636 ms (0%) 665 ms (+28.2% 🔺) 1.4 s
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 318 ms (-37.42% 🔽) 517 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 560 ms (+65.48% 🔺) 575 ms

@umputun umputun merged commit 2d3677d into master Apr 15, 2022
@umputun umputun deleted the clean-testid branch April 15, 2022 17:39
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants