Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update size-limit and move to app preset metrics #1325

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

akellbl4
Copy link
Collaborator

No description provided.

@akellbl4 akellbl4 requested a review from umputun as a code owner April 12, 2022 17:11
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1325 (778fb7b) into master (5de9544) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         136      136           
  Lines        3071     3071           
  Branches      689      689           
=======================================
  Hits         1495     1495           
  Misses       1565     1565           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de9544...778fb7b. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (+100% 🔺) 799 ms (+100% 🔺) 839 ms
public/remark.mjs 67.56 KB (0%) 1.4 s (+100% 🔺) 978 ms (+100% 🔺) 2.4 s
public/remark.css 8.28 KB (0%) 166 ms (+100% 🔺) 0 ms (+100% 🔺) 166 ms
public/last-comments.mjs 30.37 KB (0%) 608 ms (+100% 🔺) 517 ms (+100% 🔺) 1.2 s
public/deleteme.mjs 9.92 KB (0%) 199 ms (+100% 🔺) 459 ms (+100% 🔺) 657 ms
public/counter.mjs 749 B (0%) 15 ms (+100% 🔺) 350 ms (+100% 🔺) 365 ms

@akellbl4
Copy link
Collaborator Author

akellbl4 commented Apr 12, 2022

We've got app preset and it just created first record and didn't compare results from the previous result of file preset

I pulled this results from here
CleanShot 2022-04-12 at 10 15 04@2x

@umputun
Copy link
Owner

umputun commented Apr 12, 2022

we good to merge it?

@umputun umputun merged commit 5ed9e9d into master Apr 12, 2022
@umputun umputun deleted the update-size-limit branch April 12, 2022 17:18
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants