Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling sensitive data in Umbraco Forms #6412

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Handling sensitive data in Umbraco Forms #6412

merged 7 commits into from
Sep 16, 2024

Conversation

eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Sep 12, 2024

Description

Created a section "Handling sensitive data in Umbraco Forms" at the end of the Security article.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

v10, 12, 13 and 14

Deadline (if relevant)

Anytime

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💪
I've added a couple of comments.

Does it make sense to add a bit more information about the feature in the first part?
Like, talking about the default Sensitive Data user group, explaining what it is and what it means to be a part of this group? Or perhaps it could be enough to link to the article about this in the Umbraco CMS docs? 🤔

Also, it's a guide in the Reference section 😅
I think this is by far the best place for this information, but... the over all structure isn't great 🤷‍♀️ Something to tackle at a later point I think 😁

14/umbraco-forms/developer/security.md Outdated Show resolved Hide resolved
14/umbraco-forms/developer/security.md Outdated Show resolved Hide resolved
14/umbraco-forms/developer/security.md Outdated Show resolved Hide resolved
14/umbraco-forms/developer/security.md Outdated Show resolved Hide resolved
eshanrnh and others added 4 commits September 12, 2024 13:47
Co-authored-by: sofietoft <stk@umbraco.com>
Co-authored-by: sofietoft <stk@umbraco.com>
Co-authored-by: sofietoft <stk@umbraco.com>
@eshanrnh
Copy link
Contributor Author

Thanks for the review, @sofietoft 🙌 I've incorporated the comments and added a link to the CMS article.

I agree regarding the structure of the article but the entire section might need some revamping at some point of time 🙈

If these changes look fine, I'll make them for the rest of the versions too.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💪

@eshanrnh eshanrnh merged commit 4f0984e into main Sep 16, 2024
18 of 19 checks passed
@eshanrnh eshanrnh deleted the sensitive-data branch September 16, 2024 08:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants