-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling sensitive data in Umbraco Forms #6412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💪
I've added a couple of comments.
Does it make sense to add a bit more information about the feature in the first part?
Like, talking about the default Sensitive Data user group, explaining what it is and what it means to be a part of this group? Or perhaps it could be enough to link to the article about this in the Umbraco CMS docs? 🤔
Also, it's a guide in the Reference section 😅
I think this is by far the best place for this information, but... the over all structure isn't great 🤷♀️ Something to tackle at a later point I think 😁
Co-authored-by: sofietoft <stk@umbraco.com>
Co-authored-by: sofietoft <stk@umbraco.com>
Co-authored-by: sofietoft <stk@umbraco.com>
Thanks for the review, @sofietoft 🙌 I've incorporated the comments and added a link to the CMS article. I agree regarding the structure of the article but the entire section might need some revamping at some point of time 🙈 If these changes look fine, I'll make them for the rest of the versions too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💪
Description
Created a section "Handling sensitive data in Umbraco Forms" at the end of the Security article.
Type of suggestion
Product & version (if relevant)
v10, 12, 13 and 14
Deadline (if relevant)
Anytime