Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues and improve extension #786

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

whosydd
Copy link

@whosydd whosydd commented May 27, 2023

Introduction

I just did some simple tests for all of this. So maybe you should do more or make it better.
If you have question, just connect me, I'd be happy to help you out.
BTW, if you accept this, maybe you should edit README, make it match your style.

Fix issue #578

Now extension will save year to workspaceState. So it will generate like 1997-2023 when you reset old license.

refer https://code.visualstudio.com/api/references/vscode-api#Memento

Fix issue #579

Get author by git config --global --get user.name if not set author from license.author.

Improve

Explorer context commands

Now you can choose license from explorer/context
image

Downloading progress

You can see this progress when generate license

If you don't like Downloading..., just change it :)

image

Easy to set default license

  • quickpick item
    image

  • settings.json
    image

Rename command titles for adapting to vscode style

- fix issues
- add button for quickpick item
- add progress for download license
- add explorer context panel
- reset 'license.default' setting's options
- rename title for commands
- update version to 0.10.0
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Attention: 230 lines in your changes are missing coverage. Please review.

Comparison is base (a9395cf) 42.80% compared to head (9217de5) 35.89%.

Files Patch % Lines
src/commands/index.ts 20.72% 218 Missing ⚠️
src/config/index.ts 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   42.80%   35.89%   -6.92%     
==========================================
  Files           4        4              
  Lines         556      677     +121     
  Branches       39       39              
==========================================
+ Hits          238      243       +5     
- Misses        318      434     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ultram4rine ultram4rine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @whosydd, first of all, thanks for you work, it looks very good. But now there is a problem with a web build, can you take a look at it?

src/commands/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/commands/index.ts Outdated Show resolved Hide resolved
@ultram4rine ultram4rine added the enhancement New feature or request label May 27, 2023
@ultram4rine ultram4rine linked an issue May 27, 2023 that may be closed by this pull request
Copy link
Owner

@ultram4rine ultram4rine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to request changes 😕

@ultram4rine
Copy link
Owner

ultram4rine commented May 27, 2023

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@whosydd whosydd requested a review from ultram4rine May 27, 2023 19:30
@ultram4rine ultram4rine linked an issue May 28, 2023 that may be closed by this pull request
@ultram4rine ultram4rine added this to the v0.10.0 milestone May 28, 2023
src/commands/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: autoassign author from git feat: autoupdate license year if set to auto
2 participants