-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues and improve extension #786
base: master
Are you sure you want to change the base?
Conversation
- fix issues - add button for quickpick item - add progress for download license
- add explorer context panel - reset 'license.default' setting's options - rename title for commands - update version to 0.10.0
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
- Coverage 42.80% 35.89% -6.92%
==========================================
Files 4 4
Lines 556 677 +121
Branches 39 39
==========================================
+ Hits 238 243 +5
- Misses 318 434 +116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @whosydd, first of all, thanks for you work, it looks very good. But now there is a problem with a web build, can you take a look at it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to request changes 😕
@whosydd for getting author username you can try to use this: https://github.com/microsoft/vscode/blob/eef30e7165e19b33daa1e15e92fa34ff4a5df0d3/extensions/git/src/api/git.d.ts#L183 |
Introduction
I just did some simple tests for all of this. So maybe you should do more or make it better.
If you have question, just connect me, I'd be happy to help you out.
BTW, if you accept this, maybe you should edit README, make it match your style.
Fix issue #578
Now extension will save
year
to workspaceState. So it will generate like1997-2023
when you reset old license.Fix issue #579
Get author by
git config --global --get user.name
if not set author fromlicense.author
.Improve
Explorer context commands
Now you can choose license from
![image](https://private-user-images.githubusercontent.com/22630678/241358694-386035be-38c2-4bcf-b76c-0fad30e57d7d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDIzMDEsIm5iZiI6MTcyNjE0MjAwMSwicGF0aCI6Ii8yMjYzMDY3OC8yNDEzNTg2OTQtMzg2MDM1YmUtMzhjMi00YmNmLWI3NmMtMGZhZDMwZTU3ZDdkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDExNTMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4OGFlZjU4MDkwZWNlNjA4MDMzMDRlNzYyNTNiNjY2NTE4MWMwNDA3NzM5NmQwMzNiODMwOGQ5ZDA5NDk1NjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xYwYkmzSgPa2IaAEf0souXWEAWWA1IrPWjGX_GvprUY)
explorer/context
Downloading progress
You can see this progress when generate license
Easy to set default license
quickpick item
![image](https://private-user-images.githubusercontent.com/22630678/241359260-b7126566-2d56-4f58-a977-efd22166f5e6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDIzMDEsIm5iZiI6MTcyNjE0MjAwMSwicGF0aCI6Ii8yMjYzMDY3OC8yNDEzNTkyNjAtYjcxMjY1NjYtMmQ1Ni00ZjU4LWE5NzctZWZkMjIxNjZmNWU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDExNTMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyMTUwYWM3NDI1Yjk0ZDA1MmJiOTY1YzRmMTI1NmFjN2RjZDZjM2IyY2M0ODM0NWQwN2JmNjVkMWEwOGI3MmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Fa6IbOypMpZ9-tBM5MfUc1GEfKEh0UPXZptywa7UcQc)
settings.json
Rename command titles for adapting to vscode style