Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcam show fix #9847

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Webcam show fix #9847

merged 3 commits into from
Oct 18, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 18, 2022

May resolve #9844

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refined image display logic in the YOLOv5 repository.

πŸ“Š Key Changes

  • Removed the check_imshow function check from the models/common.py file.
  • Simplified the image display logic within the _run method to check if it's running in a notebook environment directly.
  • Eliminated an assertion from check_imshow in utils/general.py, which checked for non-interactive environments like SSH terminals or GitHub CI.

🎯 Purpose & Impact

  • 🎨 Enhances compatibility by streamlining how images are displayed, directly checking if the code is executed within a notebook.
  • πŸ› οΈ Improves maintainability by reducing the complexity of the code related to image visualization.
  • πŸš€ Ensures that end-users experience seamless image displays while using notebooks, and developers have a clearer codebase.

The modifications pave the way for a smoother experience when displaying images in different environments, particularly important for those interfacing with the YOLOv5 model through interactive notebooks.

glenn-jocher and others added 3 commits October 18, 2022 22:10
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING Environment does not support cv2.imshow() or PIL Image.show()
1 participant