Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_url('https://ultralytics.com') #9610

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 26, 2022

Failing on missing path, i.e. no 'www.'

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Optimization of URL validation in download utility.

πŸ“Š Key Changes

  • Simplified the URL validation check by removing the requirement that the URL must have a path component.

🎯 Purpose & Impact

  • Improves URL checking logic to consider URLs without paths as valid.
  • May prevent potential bugs related to URL validation and ensure that more types of URLs can be used without issues.
  • Users might experience enhanced flexibility and fewer errors when interacting with functions that verify URLs. πŸŒβœ…

Failing on missing path, i.e. no 'www.'

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Sep 26, 2022
@glenn-jocher glenn-jocher merged commit 1460e57 into master Sep 26, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch September 26, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant