Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check_requirements('flatbuffers==1.12') #9514

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 20, 2022

Legacy constraint, no longer required.

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced TensorFlow export compatibility in YOLOv5.

πŸ“Š Key Changes

  • πŸ›  Removed version check for flatbuffers before importing TensorFlow.
  • 🧹 Cleaned up TensorFlow export conditions to ensure clearer logic and prevent simultaneous export of TFLite and TF.js formats.

🎯 Purpose & Impact

  • βœ”οΈ Improves the smoothness and reliability of exporting models to TensorFlow formats.
  • πŸš€ Enables users to export their models to their desired format without encountering version-related import errors that previously existed due to the flatbuffers dependency.
  • πŸ” Ensures users can confidently export models by enforcing separate export paths for TFLite and TF.js, preventing confusion and potential errors.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit e233c03 into master Sep 20, 2022
@glenn-jocher glenn-jocher deleted the remove/flatbuffers branch September 20, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant