Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comet Image Logging Fix #9498

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

DN6
Copy link
Contributor

@DN6 DN6 commented Sep 19, 2022

When doing some additional testing on the Comet Logger I caught a couple of issues.

  1. The images being logged to Comet are not in the native scale, while the bounding boxes are. This leads to bounding boxes being unaligned across images
  2. Since YOLO runs a final validation run after the training is finished, images logged in the final epoch were being logged again in the validation run.

This PR fixes both these issues.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced Comet.ml logging in YOLOv5 with threshold parameters and image logging improvements.

πŸ“Š Key Changes

  • πŸ“ˆ Import of PIL library.
  • ✨ Added logging of validation IOU and confidence thresholds to Comet.ml.
  • πŸ–ΌοΈ Store logged image names to avoid duplication.
  • πŸ”„ Switched to logging the native-scaled images directly using PIL, instead of processing them.

🎯 Purpose & Impact

  • βš™οΈ The addition of PIL allows for better image handling during logging.
  • πŸ“Š By logging validation thresholds, users gain insights into the model validation process.
  • 🚫 Avoiding duplicate image logs helps in maintaining a clean and efficient logging environment.
  • 🌁 Logging native-resolution images gives a more accurate visual representation of model predictions.
  • πŸ› οΈ Overall, these changes enhance the Comet.ml integration, providing users with a more detailed and streamlined experiment tracking experience.

@DN6
Copy link
Contributor Author

DN6 commented Sep 19, 2022

Hi @glenn-jocher @AyushExel. I was preparing some more examples for the Comet integration and caught a couple of bugs on the image logging side. This PR is to fix them.

Would appreciate you taking a look. Thank you!

@glenn-jocher glenn-jocher merged commit 0b724c5 into ultralytics:master Sep 19, 2022
@glenn-jocher
Copy link
Member

@DN6 Fixes look good. PR is is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants