Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not move downloaded zips #9455

Merged
merged 2 commits into from
Sep 17, 2022
Merged

Do not move downloaded zips #9455

merged 2 commits into from
Sep 17, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 17, 2022

Prevent multiple downloads on HUB of same dataset

@kalenmike

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhancement to file download handling in the YOLOv5 codebase.

📊 Key Changes

  • Simplified the logic for determining the destination filename when downloading a file.
  • Modified the control flow to directly use the local file path if the file already exists in the current directory.

🎯 Purpose & Impact

  • Reduction of redundancy: Prevents unnecessary renaming of files, resulting in cleaner, more efficient file handling.
  • Improved code clarity: Makes it easier for developers to understand what happens during the file download process.
  • Enhanced user experience: Users can expect more straightforward and reliable file downloads with fewer errors and better logging.

Prevent multiple downloads on HUB of same dataset

@kalenmike 

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Sep 17, 2022
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 4a43080 into master Sep 17, 2022
@glenn-jocher glenn-jocher deleted the update/HUB_downloads branch September 17, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant