Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue on Docker fail (all backends) fix #9433

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 15, 2022

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced robustness in Docker image deployment workflow πŸ’ΌπŸ³

πŸ“Š Key Changes

  • Removed the continue-on-error flag from the initial job setup.
  • Added continue-on-error: true to individual Docker image build steps for arm64, CPU, and GPU.

🎯 Purpose & Impact

  • Purpose: To ensure that if one image build fails (arm64, CPU, or GPU), the rest of the builds can continue instead of the entire job failing immediately. πŸ”„
  • Impact: Increases the chances of successfully building and pushing at least some Docker images, avoiding an all-or-nothing scenario and ensuring partial progress in case of issues. This helps maintain a continuous delivery flow. πŸš€

This change is most relevant to developers and users who rely on Ultralytics' Docker images, as it affects the reliability and availability of the published images.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Sep 15, 2022
@glenn-jocher glenn-jocher merged commit abea53e into master Sep 15, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch September 15, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant