Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for *.pfm images #9230

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add support for *.pfm images #9230

merged 1 commit into from
Aug 31, 2022

Conversation

spacewalk01
Copy link
Contributor

@spacewalk01 spacewalk01 commented Aug 31, 2022

Solved the following issue:
#9222 (comment)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Expanded image format support in YOLOv5 data loaders.

πŸ“Š Key Changes

  • Added support for .pfm image format files.

🎯 Purpose & Impact

  • Enhanced Flexibility: Users can now use .pfm (Portable Float Map) files for input, which is beneficial for depth maps or HDR images.
  • Broader Applicability: The YOLOv5 model can be trained on a more diverse set of image data, potentially improving its utility in fields that use this format, like computer vision research or image processing.

@spacewalk01 spacewalk01 mentioned this pull request Aug 31, 2022
1 task
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @spacewalk01, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

@spacewalk01
Copy link
Contributor Author

Tested 'pfm' extension with opencv imread:
image

@glenn-jocher
Copy link
Member

@spacewalk01 thanks for the PR! Have you been able to train correctly with *.pfm images on this branch?

@glenn-jocher glenn-jocher changed the title add support for pfm image Add support for *.pfm images Aug 31, 2022
@glenn-jocher glenn-jocher linked an issue Aug 31, 2022 that may be closed by this pull request
1 task
@glenn-jocher glenn-jocher merged commit 79e181a into ultralytics:master Aug 31, 2022
@glenn-jocher glenn-jocher changed the title Add support for *.pfm images Add support for *.pfm images Aug 31, 2022
@glenn-jocher
Copy link
Member

@spacewalk01 PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

@spacewalk01
Copy link
Contributor Author

Oh you merged, I was trying to test training model with pfm images. I will test it and fix if there is any problem.

@urbansound8K
Copy link

urbansound8K commented Sep 5, 2022

image

I could not train??

AssertionError: train: No labels found in D:\rty\yolov5\datasets\coco128\labels\train2017.cache, can not start training. See https://docs.ultralytics.com/yolov5/tutorials/train_custom_data

the labels are there when I change the images extension, it works well

I used MiDaS to get the depth.
please help?
thanks a lot

ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
@glenn-jocher
Copy link
Member

@urbansound8K it seems that the issue might be related to the labels for the pfm images. We recommend verifying the label files and ensuring they are correctly formatted and in the expected directory. πŸ“ You can find guidelines for training custom data in the YOLOv5 documentation at https://docs.ultralytics.com/yolov5/tutorials/train_custom_data. Let us know if you need further assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

training with .pfm extension
3 participants