Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClassificationModel TF export assert #9226

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 30, 2022

Export to TF not yet supported, warning alerts users.

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancements to the export functionality of YOLOv5 models with explicit support for detection models.

πŸ“Š Key Changes

  • πŸ”„ Changed import in export.py to include ClassificationModel along with Detect.
  • βœ… Added assertion to prevent the export of ClassificationModel to TensorFlow formats, as this is not yet supported.

🎯 Purpose & Impact

  • πŸ’‘ The purpose of these changes is to prepare the code base for future ClassificationModel support while maintaining stability.
  • πŸ” By adding an assertion, users are clearly informed that exporting classification models to TensorFlow formats is currently unavailable, preventing confusion or errors.
  • πŸ› οΈ The impact for users is minimal at this stage, as it’s mainly a preventive measure, but it sets the stage for smoother expansions to model export capabilities in upcoming versions.

Export to TF not yet supported, warning alerts users.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher linked an issue Aug 30, 2022 that may be closed by this pull request
1 task
@glenn-jocher
Copy link
Member Author

@AyushExel I'm adding a warning here on export.py to alert users that ClassificatioModels are not TF export supported yet.

@glenn-jocher glenn-jocher merged commit 4a37381 into master Aug 30, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch August 30, 2022 14:18
@glenn-jocher glenn-jocher mentioned this pull request Aug 30, 2022
1 task
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Add ClassificationModel TF export assert

Export to TF not yet supported, warning alerts users.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question about export tflite
1 participant