Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji-safe default logging #8888

Merged
merged 2 commits into from
Aug 6, 2022
Merged

emoji-safe default logging #8888

merged 2 commits into from
Aug 6, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 6, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR removes emoji usage from log output in the Ultralytics YOLOv5 repository.

πŸ“Š Key Changes

  • Removed the emojis function call from log outputs across various files (autoanchor.py, autobatch.py, general.py, loggers/__init__.py, torch_utils.py, val.py).
  • Altered logging behavior to no longer process emojis in general.py.

🎯 Purpose & Impact

  • The main goal seems to be simplifying log messages by removing emojis, which may enhance readability and avoid potential issues with logging systems that do not support emoji characters.
  • The impact will be logs that are more compatible with various environments and possibly clearer to understand for users who prefer text-only messages.

@glenn-jocher glenn-jocher self-assigned this Aug 6, 2022
@glenn-jocher glenn-jocher merged commit 8f28ea4 into master Aug 6, 2022
@glenn-jocher glenn-jocher deleted the update/emojis branch August 6, 2022 10:30
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* emoji-safe default logging

* implement everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant