Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export.py replace check_file -> check_yaml #8852

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 3, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement of YAML dataset validation and reduction of dependencies in TensorFlow Lite export.

πŸ“Š Key Changes

  • Removed check_file function and integrated check_yaml for dataset validation in TensorFlow Lite export process.
  • Minor code cleanup in export.py, changing one line related to dataset loading.

🎯 Purpose & Impact

  • 🎯 Purpose: The update ensures datasets are specifically validated as YAML files, improving reliability. Additionally, it contributes to cleaner and more maintainable code by using a more appropriate validation function.
  • πŸ” Impact: Users exporting models to TensorFlow Lite may notice improved validation messages if there are issues with the dataset configuration. There should be no noticeable impact on the export functionality for users with correctly formatted datasets.

@glenn-jocher glenn-jocher self-assigned this Aug 3, 2022
@glenn-jocher glenn-jocher merged commit 628c05c into master Aug 3, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch August 3, 2022 21:38
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* export.py replace `check_file` -> `check_yaml`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant