Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_file(data) i.e. --data coco128.yaml #8851

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 3, 2022

Partially related to #8842

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved file validation and dataset loading in TensorFlow Lite export.

πŸ“Š Key Changes

  • Replaced url2file function with check_file to validate dataset paths or URLs.
  • Ensured the TensorFlow Lite export uses validated file paths during the conversion process.

🎯 Purpose & Impact

  • The change ensures that file paths or URLs for datasets are properly checked and validated, reducing errors during model export.
  • Users should experience more reliable exports to TensorFlow Lite format, especially when providing dataset paths for quantization, enhancing the usability of the export feature. πŸ“ˆ
  • This can potentially save time and frustration for users by preventing common file path issues early in the export process. πŸ› οΈ

@glenn-jocher glenn-jocher self-assigned this Aug 3, 2022
@glenn-jocher glenn-jocher merged commit 6884da3 into master Aug 3, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch August 3, 2022 21:32
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Add check_file(data) i.e. `--data coco128.yaml`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant