Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix BGR->RGB Bug in albumentations #8641" #8727

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Revert "Fix BGR->RGB Bug in albumentations #8641" #8727

merged 1 commit into from
Jul 26, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 26, 2022 •
edited by UltralyticsAssistant
Loading

Reverts ultralytics/yolov5#8695Reverts #8695 to resolve bug #8641

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Simplification of image augmentation in YOLOv5 by removing unnecessary color space conversion.

📊 Key Changes

  • Removed the code flipping image channels from RGB to BGR and back during augmentations.
  • Updated the augmentation process to work directly with the original image format.

🎯 Purpose & Impact

  • 📈 Increased Efficiency: Skipping the color space conversion step should reduce computation time during augmentation.
  • 🔍 Streamlined Code: The change simplifies the codebase, making it cleaner and easier to maintain.
  • 🖼 Consistency in Image Processing: Ensures image data remains consistent in its original format throughout processing.

@glenn-jocher glenn-jocher linked an issue Jul 26, 2022 that may be closed by this pull request
#8641 regressing bug #8724
Closed
2 tasks
@glenn-jocher glenn-jocher merged commit c775a29 into master Jul 26, 2022
@glenn-jocher glenn-jocher deleted the revert-8695-fix/albumentations_rgb branch July 26, 2022 17:00
@glenn-jocher glenn-jocher mentioned this pull request Jul 26, 2022
Closed
2 tasks
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
@glenn-jocher
Revert "Fix BGR->RGB Bug in albumentations ultralytics#8641" (ultraly…
467f18e 
…tics#8727)

Revert "Fix BGR->RGB Bug in albumentations ultralytics#8641 (ultralytics#8695)"

This reverts commit 2e1291f.
@Hojland Hojland mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#8641 regressing bug
1 participant
@glenn-jocher