Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix BGR->RGB Bug in albumentations #8641" #8726

Closed
wants to merge 3 commits into from

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 26, 2022

Reverts #8695 to resolve bug #8641

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refactoring Image Augmentation and Color-Space Conversion

πŸ“Š Key Changes

  • Simplified code by combining two lines into a single line when applying image transformations and relabeling.
  • Corrected color-space conversions, enforcing RGB usage over BGR to maintain consistency in the augmentation process.
  • Updated dataloader to apply augmentations directly to images in RGB, instead of the previously used BGR format.

🎯 Purpose & Impact

  • Improves code efficiency and readability, reducing the potential for errors.
  • Ensures that image manipulations are performed consistently in the RGB color space, which aligns with common image processing standards.
  • The changes may lead to subtle differences in training data presentation, possibly affecting model training outcomes. Users can expect more standardized image handling throughout the augmentation pipeline. 🌈

@glenn-jocher glenn-jocher self-assigned this Jul 26, 2022
@glenn-jocher glenn-jocher linked an issue Jul 26, 2022 that may be closed by this pull request
2 tasks
@glenn-jocher glenn-jocher deleted the revert-8695-fix/albumentations_rgb branch July 26, 2022 17:00
@glenn-jocher glenn-jocher removed a link to an issue Jul 26, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant