Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cv2 window init code on Windows #8712

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 25, 2022

Resolves #8642

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved compatibility for window management on Linux during detection in YOLOv5.

πŸ“Š Key Changes

  • Imported platform module in detect.py.
  • Adjusted window streaming condition to be specific to the Linux operating system.

🎯 Purpose & Impact

  • 🐧 Ensures that only on Linux, new windows can be created or resized to display detection results, preventing potential issues on other OS like Windows or MacOS.
  • πŸ‘€ Enhanced user experience for Linux users by allowing window resizing, aligning the behavior with users' expectations of window management on their OS.
  • βœ… This update possibly prevents errors or unexpected behaviors related to window management for users on non-Linux systems.

@glenn-jocher glenn-jocher self-assigned this Jul 25, 2022
@glenn-jocher glenn-jocher merged commit 7215a0f into master Jul 25, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch July 25, 2022 11:57
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There was a problem using detect.py
1 participant