Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken is_docker check #8711

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix: broken is_docker check #8711

merged 2 commits into from
Jul 26, 2022

Commits on Jul 26, 2022

  1. fix: broken is_docker check 

    Checking if ``/workspace`` exists is not a reliable method to check if
the process runs in a docker container.

Reusing the logic from the npm "is-docker" package to check if the
process runs in a container.
References: https://github.com/sindresorhus/is-docker/blob/main/index.js

Fixes #8710.
    Maximilian Strobel authored and Maximilian Strobel committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    fd59c82 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/is_docker

    @glenn-jocher
    glenn-jocher authored Jul 26, 2022
    Configuration menu
    Copy the full SHA
    b0b3a80 View commit details
    Browse the repository at this point in the history