Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check TensorBoard logger before adding graph #8664

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

JarnoRFB
Copy link
Contributor

@JarnoRFB JarnoRFB commented Jul 21, 2022

Otherwise, an error is thrown if the tensorboard logger is not included.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement to logging logic to prevent unnecessary warnings when using TensorBoard without sync_bn.

πŸ“Š Key Changes

  • Added a check to ensure Tensorboard (self.tb) is active before processing graph additions.
  • Maintains the previous condition to skip the graph addition step when sync_bn (synchronized batch normalization) is enabled.

🎯 Purpose & Impact

  • The change aims to reduce unnecessary warnings about JIT trace issues when TensorBoard is not in use.
  • Users will experience cleaner logs and avoid potential confusion caused by irrelevant warnings. This update should have no impact on model training or inference behavior, but it will improve the user experience for developers monitoring training progress with TensorBoard. πŸ“ˆβœ¨

Otherwise, an error is thrown if the tensorboard logger is not included.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @JarnoRFB, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature  # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
  • βœ… Verify all Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher glenn-jocher changed the title Check tensorboard logger before adding graph Check TensorBoard logger before adding graph Jul 21, 2022
@glenn-jocher glenn-jocher merged commit 602d7ff into ultralytics:master Jul 21, 2022
@glenn-jocher
Copy link
Member

@JarnoRFB PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Otherwise, an error is thrown if the tensorboard logger is not included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants