-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade onnxsim to v0.4.1 #8632
Conversation
Signed-off-by: daquexian <daquexian566@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @daquexian, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
@daquexian I get a failure in Colab when testing this PR. Something seems off about the |
@daquexian I added onnxruntime install prior to the new onnxsim 0.4.1 install and this appears to resolve the issue. Not sure what the problem was. |
@daquexian PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
@glenn-jocher Thanks for your work! |
* upgrade onnxsim to v0.4.1 Signed-off-by: daquexian <daquexian566@gmail.com> * Update export.py * Update export.py * Update export.py * Update export.py * Update export.py Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@daquexian you're welcome! It's a team effort and we're grateful for all the support from the YOLO community and the Ultralytics team. If you have any more questions or suggestions, feel free to reach out anytime. |
I'm the author of onnx-simplifier. Recently I published onnxsim v0.4.1. In the latest version, dynamic input shapes are natively supported. Extra flags like
dynamic_input_shapes
andinput_shapes
are not needed anymore.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced ONNX export functionality and requirements adjustment for the YOLOv5 model.
📊 Key Changes
export.py
, removing the need to specify dynamic input shapes directly.onnxruntime-gpu
oronnxruntime
based on CUDA availability for ONNX model simplification.export.py
to clarify that the optimization process requires the CPU device.onnx-simplifier
inrequirements.txt
to>=0.4.1
.🎯 Purpose & Impact
These changes aim to streamline the process for users exporting YOLOv5 models to ONNX format, which may improve user experience and broaden the deployment possibilities of YOLOv5 in different environments and platforms.