Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML export --half fix #8522

Merged
merged 1 commit into from
Jul 8, 2022
Merged

XML export --half fix #8522

merged 1 commit into from
Jul 8, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 8, 2022

Improved error reporting for #8519

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement of the model conversion compatibility in yolov5 export process.

πŸ“Š Key Changes

  • πŸ›  Improved assertion logic in the export script to relax constraints on using --half precision.
  • πŸ—‘οΈ Removed the unnecessary check for OpenVINO's XML format when using --half precision.

🎯 Purpose & Impact

  • 🎨 The update allows users more flexibility by enabling half-precision model export (--half) on CPU for CoreML models, which wasn't allowed before.
  • ✨ It removes a constraint that could cause confusion or errors when exporting models for different platforms.
  • πŸ‘₯ Users working with CoreML will benefit from performance improvements due to half-precision exports without needing a GPU.

Improved error reporting for #8519
@glenn-jocher glenn-jocher self-assigned this Jul 8, 2022
@glenn-jocher glenn-jocher linked an issue Jul 8, 2022 that may be closed by this pull request
2 tasks
@glenn-jocher glenn-jocher merged commit c215e87 into master Jul 8, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch July 8, 2022 11:49
Shivvrat pushed a commit to Shivvrat/epic-yolov5 that referenced this pull request Jul 12, 2022
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export .pt to .onnx with half precision failure.
1 participant