Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify benchmarks.py assertions #8515

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Simplify benchmarks.py assertions #8515

merged 1 commit into from
Jul 7, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 7, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refinement of assertion messages in YOLOv5 benchmarking script.

πŸ“Š Key Changes

  • Streamlined assertion error messages by removing specific format names (like Edge TPU and TF.js) and improving clarity.
  • Ensured macOS version compatibility is clearly mentioned for CoreML inference.

🎯 Purpose & Impact

  • 🎨 Simplifies error messages for better user understanding when a certain inference format is not supported.
  • 🍏 Clarifies system requirements for Mac users utilizing CoreML, preventing confusion and potential errors.
  • πŸ”§ Enhances overall user experience with cleaner, more general alerts during benchmarking tasks.

@glenn-jocher glenn-jocher self-assigned this Jul 7, 2022
@glenn-jocher glenn-jocher merged commit f17444a into master Jul 7, 2022
@glenn-jocher glenn-jocher deleted the update/bench branch July 7, 2022 21:46
Shivvrat pushed a commit to Shivvrat/epic-yolov5 that referenced this pull request Jul 12, 2022
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant