Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Expose OpenVINO batch_size similarly to TensorRT" #8510

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Revert "Expose OpenVINO batch_size similarly to TensorRT" #8510

merged 1 commit into from
Jul 7, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 7, 2022 •
edited by UltralyticsAssistant
Loading

Reverts #8437, resolves #8509

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced model compatibility with OpenVINO by removing unnecessary batch size setting.

📊 Key Changes

  • Removed the line setting batch_size from the OpenVINO model loading section in models/common.py.

🎯 Purpose & Impact

  • ⚙️ Purpose: To streamline the model-loading process for OpenVINO-backed models, ensuring there's no manual batch size configuration needed.
  • 🚀 Impact: Offers a smoother integration with OpenVINO, potentially improving user experience by preventing batch size-related errors and making the process more foolproof for all users, including those less familiar with the intricacies of model deployment.

@glenn-jocher glenn-jocher self-assigned this Jul 7, 2022
@glenn-jocher glenn-jocher merged commit 9d7bc06 into master Jul 7, 2022
@glenn-jocher glenn-jocher deleted the revert-8437-patch-2 branch July 7, 2022 18:13
This was referenced Jul 7, 2022
Closed
Merged
Shivvrat pushed a commit to Shivvrat/epic-yolov5 that referenced this pull request Jul 12, 2022
@glenn-jocher @Shivvrat
Revert "Expose OpenVINO batch_size similarly to TensorRT" (ultralyt…
ad26981 
…ics#8510)

Revert "Expose OpenVINO `batch_size` similarly to TensorRT (ultralytics#8437)"

This reverts commit da2ee39.
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
@glenn-jocher
Revert "Expose OpenVINO batch_size similarly to TensorRT" (ultralyt…
11354c5 
…ics#8510)

Revert "Expose OpenVINO `batch_size` similarly to TensorRT (ultralytics#8437)"

This reverts commit da2ee39.
@Hojland Hojland mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glenn-jocher glenn-jocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'openvino.pyopenvino.Model' object has no attribute 'batch_size'
1 participant
@glenn-jocher