Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT --half fix autocast images to FP16 #8435

Merged
merged 2 commits into from
Jul 1, 2022
Merged

TRT --half fix autocast images to FP16 #8435

merged 2 commits into from
Jul 1, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 1, 2022 •
edited by UltralyticsAssistant
Loading

Resolves bug raised in #7822

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Implementing automatic FP16 (half precision) image casting in YOLOv5 for improved efficiency.

📊 Key Changes

  • Added a conditional check to automatically convert input images to FP16 before inference if the model is set to use FP16 and the images aren't already in that format.

🎯 Purpose & Impact

  • Purpose: This change is intended to ensure that the model uses the correct precision for image inputs to match the model's operating precision mode (FP16 in this case), which wasn't explicitly enforced before.
  • Impact: Users can expect more consistent and possibly faster performance, especially on hardware that benefits from half-precision computations. This is particularly relevant for GPUs that are optimized for FP16 operations, leading to more efficient utilization of resources. 🚀

@glenn-jocher glenn-jocher self-assigned this Jul 1, 2022
@glenn-jocher glenn-jocher linked an issue Jul 1, 2022 that may be closed by this pull request
inference with tensorrt on torch.hub doesnt work properly #7822
Closed
2 tasks
@glenn-jocher glenn-jocher merged commit d94b470 into master Jul 1, 2022
@glenn-jocher glenn-jocher deleted the trt/fix branch July 1, 2022 13:41
@glenn-jocher glenn-jocher mentioned this pull request Jul 1, 2022
Closed
2 tasks
Shivvrat pushed a commit to Shivvrat/epic-yolov5 that referenced this pull request Jul 12, 2022
@glenn-jocher @Shivvrat
TRT --half fix autocast images to FP16 (ultralytics#8435)
c77fb2f 
* TRT `--half` fix autocast images to FP16

Resolves bug raised in ultralytics#7822

* Update common.py
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
@glenn-jocher
TRT --half fix autocast images to FP16 (ultralytics#8435)
cf46c0c 
* TRT `--half` fix autocast images to FP16

Resolves bug raised in ultralytics#7822

* Update common.py
@Hojland Hojland mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glenn-jocher glenn-jocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inference with tensorrt on torch.hub doesnt work properly
1 participant
@glenn-jocher