Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker actions conditional on ultralytics/yolov5 repo #8060

Merged
merged 4 commits into from
May 31, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 31, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced CI and Docker workflows for better repository management πŸš€

πŸ“Š Key Changes

  • Added new environment variable outputs to the CI testing workflow.
  • Commented out the pull request trigger for Docker image publishing.
  • Added a condition to only run the Docker job for the official Ultralytics repository.

🎯 Purpose & Impact

  • πŸ›  Improves debugging by echoing additional GitHub context variables in CI.
  • πŸ“ Prevents unnecessary Docker builds on pull request events, conserving resources.
  • πŸ›‚ Ensures Docker images are only published from the main Ultralytics repository, protecting the integrity of official images and preventing accidental pushes from forks.

@glenn-jocher glenn-jocher changed the title Update ci-testing.yml Make Docker actions conditional on ultralytics/yolov5 repo May 31, 2022
@glenn-jocher glenn-jocher self-assigned this May 31, 2022
@glenn-jocher glenn-jocher merged commit 7d87b9e into master May 31, 2022
@glenn-jocher glenn-jocher deleted the update/ci branch May 31, 2022 14:36
@glenn-jocher
Copy link
Member Author

@Borda @AyushExel Docker builds no longer run on forks, thanks for the tip! The action still runs but shows as 'check skipped':

Verified on my personal fork at https://github.com/glenn-jocher/yolov5:
Screenshot 2022-05-31 at 16 43 21

tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
…tics#8060)

* Update ci-testing.yml

* Update ci-testing.yml

* Update ci-testing.yml

* Update docker.yml
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
…tics#8060)

* Update ci-testing.yml

* Update ci-testing.yml

* Update ci-testing.yml

* Update docker.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant