Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements.txt protobuf<=3.20.1 #8017

Merged
merged 3 commits into from
May 28, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 28, 2022

protobuf >=4 is unstable and breaking CI and training. Pinning to 3.20.1 temporarily to resolve. See #8012

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved package dependency management in YOLOv5's CI and requirements.

πŸ“Š Key Changes

  • Removed the fixed protobuf==3.20.1 version from CI workflow files.
  • Added protobuf<=3.20.1 constraint to the requirements.txt file.

🎯 Purpose & Impact

  • βš™οΈ Purpose: The change standardizes the version constraint for protobuf across different setup configurations, ensuring compatibility and preventing potential issues as noted in a specific YOLOv5 GitHub issue.
  • πŸš€ Impact: Users can expect more consistent installations and fewer errors related to the protobuf package version when setting up YOLOv5, leading to a smoother experience.

@glenn-jocher glenn-jocher self-assigned this May 28, 2022
@glenn-jocher glenn-jocher linked an issue May 28, 2022 that may be closed by this pull request
2 tasks
@glenn-jocher glenn-jocher changed the title Pin protobuf==3.20.1 Pin requirements.txt protobuf==3.20.1 May 28, 2022
@glenn-jocher glenn-jocher changed the title Pin requirements.txt protobuf==3.20.1 Pin requirements.txt protobuf<=3.20.1 May 28, 2022
@glenn-jocher glenn-jocher changed the title Pin requirements.txt protobuf<=3.20.1 Add requirements.txt protobuf<=3.20.1 May 28, 2022
@glenn-jocher glenn-jocher merged commit 7433d38 into master May 28, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 28, 2022 10:12
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Pin `protobuf==3.20.1`

* Update requirements.txt

* Update ci-testing.yml
@addiercv
Copy link

addiercv commented Jun 24, 2022

There is compatibility issue with tensorboard 2.9.1.

ERROR: tensorboard 2.9.1 has requirement protobuf<3.20,>=3.9.2, but you'll have protobuf 3.20.1 which is incompatible.

OS: Ubuntu 20.04 LTS
Python: 3.8.10

I changed protobuf<=3.20.1 to protobuf<3.20.0, tensorboard 2.9.1 installed successfully (all the packages are installed successfully).

@glenn-jocher
Copy link
Member Author

glenn-jocher commented Jun 26, 2022

@addiercv <=3.20.1 is fully compatible with <3.20

How to create a Minimal, Reproducible Example

When asking a question, people will be better able to provide help if you provide code that they can easily understand and use to reproduce the problem. This is referred to by community members as creating a minimum reproducible example. Your code that reproduces the problem should be:

  • βœ… Minimal – Use as little code as possible to produce the problem
  • βœ… Complete – Provide all parts someone else needs to reproduce the problem
  • βœ… Reproducible – Test the code you're about to provide to make sure it reproduces the problem

For Ultralytics to provide assistance your code should also be:

  • βœ… Current – Verify that your code is up-to-date with GitHub master, and if necessary git pull or git clone a new copy to ensure your problem has not already been solved in master.
  • βœ… Unmodified – Your problem must be reproducible using official YOLOv5 code without changes. Ultralytics does not provide support for custom code ⚠️.

If you believe your problem meets all the above criteria, please close this issue and raise a new one using the πŸ› Bug Report template with a minimum reproducible example to help us better understand and diagnose your problem.

Thank you! πŸ˜ƒ

ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Pin `protobuf==3.20.1`

* Update requirements.txt

* Update ci-testing.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant start training: TypeError: Descriptors cannot not be created directly.
2 participants