Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning emoji ⚠️ on --conf > 0.001 #8005

Merged
merged 3 commits into from
May 27, 2022
Merged

Add warning emoji ⚠️ on --conf > 0.001 #8005

merged 3 commits into from
May 27, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 27, 2022

User error persists despite warnings, adding more visible warning element. Addresses #8004

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improvement to validation script messaging with emojis.

📊 Key Changes

  • Added emojis function call in the import section of val.py.
  • Removed a LOGGER warning about an invalid mAP values due to high confidence threshold.

🎯 Purpose & Impact

  • The inclusion of emojis aims to make the script's output more user-friendly and engaging.
  • Removing the LOGGER warning about high confidence thresholds cleans up the output and may reduce confusion for users, who can now set higher confidence values without being warned of invalid mAP calculations.

@glenn-jocher glenn-jocher self-assigned this May 27, 2022
@glenn-jocher glenn-jocher changed the title Add warning emoji on --conf > 0.001 Add warning emoji ⚠️ on --conf > 0.001 May 27, 2022
@glenn-jocher glenn-jocher linked an issue May 27, 2022 that may be closed by this pull request
1 task
@glenn-jocher glenn-jocher merged commit 09ba6f6 into master May 27, 2022
@glenn-jocher glenn-jocher deleted the val/emoji branch May 27, 2022 09:49
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Add warning emoji on `--conf > 0.001`

* Update val.py
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Add warning emoji on `--conf > 0.001`

* Update val.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number labels is not same when i set different confidence
1 participant