Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVINO metadata fix2 #7954

Merged
merged 4 commits into from
May 24, 2022
Merged

OpenVINO metadata fix2 #7954

merged 4 commits into from
May 24, 2022

Conversation

xylieong
Copy link
Contributor

@xylieong xylieong commented May 24, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved compatibility within the OpenVINO export functionality and metadata file handling.

πŸ“Š Key Changes

  • Modified the way the metadata file name is constructed during OpenVINO export in export.py
  • Ensured correct Path object handling when checking for the existence of a metadata file in models/common.py

🎯 Purpose & Impact

  • πŸ›  Ensures metadata files are correctly named and stored, preventing potential export errors for OpenVINO users.
  • βš™οΈ Improves overall reliability when integrating YOLOv5 models with Intel's OpenVINO toolkit, which could lead to smoother deployment on various platforms, including those requiring FP16 or FP32 precision formats.
  • πŸš€ Users can expect more robust model export experiences, particularly when working with different data types and deploying across diverse hardware.

@xylieong
Copy link
Contributor Author

Modified metadata to be in the folder {pt_model_path}/{model name}_openvino_model

@glenn-jocher glenn-jocher changed the title Bug Fixed: OpenVINO metadata OpenVINO metadata fix2 May 24, 2022
@glenn-jocher glenn-jocher self-assigned this May 24, 2022
@glenn-jocher glenn-jocher merged commit 27911dc into ultralytics:master May 24, 2022
@glenn-jocher
Copy link
Member

@xylieong PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Bug Fixed: OpenVINO metadata

* Bug Fixed: OpenVINO metadata

* Update export.py

* Update export.py

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Bug Fixed: OpenVINO metadata

* Bug Fixed: OpenVINO metadata

* Update export.py

* Update export.py

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants