Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVINO metadata fix #7952

Merged
merged 4 commits into from
May 24, 2022
Merged

OpenVINO metadata fix #7952

merged 4 commits into from
May 24, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 24, 2022

Follows #7947

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvements in metadata handling and class loading for YOLOv5 models.

πŸ“Š Key Changes

  • Modified metadata file naming in export.py to match the model name.
  • Enhanced class names assignment in models/common.py by loading from provided data file if available.
  • Cleaned up redundant code by centralizing metadata loading in a single _load_metadata static method in models/common.py.

🎯 Purpose & Impact

  • Consistency: The changes lead to more consistent metadata files by naming them after the model they relate to.
  • Flexibility: Users can now have custom class names loaded automatically if they provide a data file, making the model usage more flexible.
  • Code Quality: Refactoring metadata loading improves code maintainability and readability, which can facilitate future development.

πŸ”„ These improvements should ease the management of model metadata and enhance the user experience for developers integrating YOLOv5 models into their applications.

@glenn-jocher glenn-jocher self-assigned this May 24, 2022
@glenn-jocher glenn-jocher merged commit 0dd66e2 into master May 24, 2022
@glenn-jocher glenn-jocher deleted the ov/metadata branch May 24, 2022 10:00
@glenn-jocher
Copy link
Member Author

@xylieong PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Rename OpenVINO meta.yaml to model name

* Rename OpenVINO meta.yaml to model name

* Rename OpenVINO meta.yaml to model name

* fix
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Rename OpenVINO meta.yaml to model name

* Rename OpenVINO meta.yaml to model name

* Rename OpenVINO meta.yaml to model name

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant