Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows cmd to count GPU devices #7891

Merged
merged 2 commits into from
May 19, 2022
Merged

Added Windows cmd to count GPU devices #7891

merged 2 commits into from
May 19, 2022

Conversation

xylieong
Copy link
Contributor

@xylieong xylieong commented May 19, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced GPU count compatibility for YOLOv5 on Windows.

πŸ“Š Key Changes

  • Updated device_count() in utils/torch_utils.py to support Windows.
  • Modified the assertion to allow the function to run on both Linux and Windows systems.
  • Adapted the command within device_count() to differentiate between Linux and Windows environments.

🎯 Purpose & Impact

  • 🎯 Purpose: Expand the usability of the YOLOv5 by allowing it to correctly count available CUDA devices on Windows, not just Linux.
  • πŸ’» Impact: Windows users can now leverage YOLOv5 with improved support for their GPU environments, leading to better accessibility and convenience for a broader user base.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @xylieong, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature  # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
  • βœ… Verify all Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher glenn-jocher merged commit f43cd53 into ultralytics:master May 19, 2022
@glenn-jocher
Copy link
Member

@xylieong PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Added Windows cmd to count GPU devices

* Cleanup

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Added Windows cmd to count GPU devices

* Cleanup

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants