Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TFDWConv() c1 == c2 check #7842

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix TFDWConv() c1 == c2 check #7842

merged 1 commit into from
May 16, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 16, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement of Depthwise Convolution Layer in TensorFlow Models.

πŸ“Š Key Changes

  • Removed the g parameter (number of groups) from TFDWConv layer initializer arguments.
  • Modified the assertion check to only require input channels (c1) to be equal to the output channels (c2), instead of also checking against the g parameter.

🎯 Purpose & Impact

  • 🧹 Simplifies the initialization of the depthwise convolution layer by removing an unnecessary parameter.
  • πŸ› οΈ Ensures the integrity of the model by checking that the number of input channels matches the number of output channels, a requirement for depthwise convolution.
  • πŸ”§ Reduces potential for configuration errors by removing the group check, which is not needed in depthwise convolutions as the input and output channels are naturally equal.
  • πŸ‘©β€πŸ’» Helps developers to work with a cleaner interface when utilizing the TFDWConv layer in their machine learning models, potentially increasing development productivity and model stability.

@glenn-jocher glenn-jocher self-assigned this May 16, 2022
@glenn-jocher glenn-jocher merged commit 2b64b45 into master May 16, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 16, 2022 16:06
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant