Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor collections and fstrings #7821

Merged
merged 4 commits into from
May 15, 2022
Merged

Refactor collections and fstrings #7821

merged 4 commits into from
May 15, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 15, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Optimizations and code cleaning in Ultralytics YOLOv5 repository.

πŸ“Š Key Changes

  • Python string formatting using f-strings for file path operations, making code more readable πŸ› οΈ.
  • Modified lists to sets in if-conditions to reduce lookup time and enhance code efficiency πŸš€.
  • Refactored equality checks from using multiple if-else to single statement handling for rotations and ranks βš™οΈ.
  • Improved exception handling by simplifying except blocks πŸ’Ό.
  • Conciseness in tensor operations, e.g., merged dimensions unpacking into a single line πŸ“.
  • General code cleanups, such as unifying iterator variables and removing unnecessary else after continue 😎.

🎯 Purpose & Impact

  • The changes prioritize code readability and performance, which can facilitate future maintenance and contributions 🌱.
  • F-string adoption is a Pythonic way to handle string operations, contributing to a more modern codebase ✨.
  • Reducing computational complexity, especially in conditionals, leads to minor performance enhancements 🏎️.
  • Clean and concise code helps both newer contributors understand the codebase and maintains a high standard for the project's code quality 🧹.
  • Overall, these changes should not affect the end-users directly but improve the developer experience and could indirectly lead to more stable releases πŸ—οΈ.

@glenn-jocher glenn-jocher self-assigned this May 15, 2022
@glenn-jocher glenn-jocher changed the title Update torch_utils.py Collections and fstring refactor May 15, 2022
@glenn-jocher glenn-jocher changed the title Collections and fstring refactor Refactor collections and fstrings May 15, 2022
@glenn-jocher glenn-jocher merged commit f000714 into master May 15, 2022
@glenn-jocher glenn-jocher deleted the update/torch_utils branch May 15, 2022 14:38
@glenn-jocher glenn-jocher mentioned this pull request May 15, 2022
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Update torch_utils.py

* Additional code refactoring

* tuples to sets

* Cleanup
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Update torch_utils.py

* Additional code refactoring

* tuples to sets

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant