Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin downloads to release version #7790

Merged
merged 2 commits into from
May 12, 2022
Merged

Pin downloads to release version #7790

merged 2 commits into from
May 12, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 12, 2022

Fixes a release version to avoid forward-compatibility issues in future releases.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced model downloading with better URL checks and GitHub API integration.

πŸ“Š Key Changes

  • πŸ” Added is_url function to verify if a URL points to an existent online file.
  • πŸ’Ύ Modified attempt_download function to:
    • Integrate with GitHub API to fetch available assets and tag names for specific release versions.
    • Handle specifying of release versions (e.g., 'v6.1') more flexibly.
    • Use a fallback list of assets and try to retrieve the latest git tag as a default if errored.

🎯 Purpose & Impact

  • πŸ— Makes downloading models more robust by checking the existence of files before attempting to download.
  • πŸ”„ Allows users to download specific versions of pretrained models easily, enhancing user experience and reproducibility.
  • πŸ”„ Potential reduction in download-related issues, ensuring more stability in the setup process for new users.

Fixes a release version to avoid forward-compatibility issues in future releases.
@glenn-jocher glenn-jocher self-assigned this May 12, 2022
@glenn-jocher glenn-jocher merged commit f3fecf9 into master May 12, 2022
@glenn-jocher glenn-jocher deleted the pin/downloads branch May 12, 2022 22:24
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* Pin downloads to release version

Fixes a release version to avoid forward-compatibility issues in future releases.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Pin downloads to release version

Fixes a release version to avoid forward-compatibility issues in future releases.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant