Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on_train_end callback #7716

Merged
merged 2 commits into from
May 6, 2022
Merged

Update on_train_end callback #7716

merged 2 commits into from
May 6, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 6, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Streamlining result logging in YOLOv5's training script.

πŸ“Š Key Changes

  • Removed a line in train.py that reported saving results to a directory.
  • Added similar logging functionality in utils/loggers/__init__.py, ensuring that results are logged through the logger object.

🎯 Purpose & Impact

  • The adjustment ensures that all logging goes through the designated logger, maintaining consistency and potentially making it easier to control output from a single point.
  • This change has a minor impact on users: anyone reviewing the training output will now receive a slightly neater log message.
  • It simplifies the codebase by removing redundant lines, thus helping contributors with clearer code to maintain.

πŸ‘©β€πŸ’»πŸ§ΉπŸ’‘

@glenn-jocher glenn-jocher self-assigned this May 6, 2022
@glenn-jocher glenn-jocher merged commit aa7a0e9 into master May 6, 2022
@glenn-jocher glenn-jocher deleted the update/ontrainend branch May 6, 2022 04:25
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant