Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FROM nvcr.io/nvidia/pytorch:22.04-py3 #7680

Merged
merged 12 commits into from
May 3, 2022
Merged

FROM nvcr.io/nvidia/pytorch:22.04-py3 #7680

merged 12 commits into from
May 3, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 3, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR updates dependencies and handling of TensorRT for better compatibility and cleanliness in Docker environments.

πŸ“Š Key Changes

  • Improved exception handling for importing TensorRT in export.py, falling back to requirements check if the initial import fails.
  • Updated the NVIDIA PyTorch Docker base image to version 22.04-py3.
  • Removed a large unnecessary directory (/opt/pytorch) in the Docker image to save space.
  • Changed the location where Arial fonts are downloaded in Dockerfiles for consistency and potential reduction in layer sizes.
  • Removed the installation of specific versions of PyTorch and torchvision, replacing it with a command to install the latest version that matches the CUDA 11.3 version, and enforced the Pillow version to be >=9.1.0.

🎯 Purpose & Impact

  • The changes in handling TensorRT import issues enhance robustness, ensuring the availability of necessary packages for GPU support without manual intervention.
  • The Docker image update reflects a move towards more current dependencies, promoting compatibility with recent codebases.
  • Space optimization in Docker images through removing unnecessary directories will lead to quicker download and deployment times for users.
  • Streamlining the font downloads into a common layer in Dockerfiles may improve build efficiency and reduce image sizes.
  • By allowing automatic installation of compatible PyTorch and torchvision versions, the project avoids potential conflicts with pre-existing installations, while specifying the Pillow version ensures compatibility with other requirements.

@glenn-jocher glenn-jocher self-assigned this May 3, 2022
@glenn-jocher glenn-jocher merged commit d4ea61e into master May 3, 2022
@glenn-jocher glenn-jocher deleted the docker branch May 3, 2022 20:47
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
* FROM nvcr.io/nvidia/pytorch:22.04-py3

* Update Docker

* Update Docker

* Update Docker

* Update Docker

* Update TRT auto-install

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Cleanup

* Cleanup

* Cleanup cpu

* Cleanup cpu

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* FROM nvcr.io/nvidia/pytorch:22.04-py3

* Update Docker

* Update Docker

* Update Docker

* Update Docker

* Update TRT auto-install

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Cleanup

* Cleanup

* Cleanup cpu

* Cleanup cpu

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* FROM nvcr.io/nvidia/pytorch:22.04-py3

* Update Docker

* Update Docker

* Update Docker

* Update Docker

* Update TRT auto-install

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Cleanup

* Cleanup

* Cleanup cpu

* Cleanup cpu

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant