Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_requirements() with cmds=() argument #7543

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 22, 2022

Refactor TRT Autoinstall via check_requirements() upgrades.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved dependency management in YOLOv5 export process to TensorRT.

πŸ“Š Key Changes

  • Removed manual install attempts of tensorrt within export.py when not found.
  • Added cmds parameter to check_requirements function in general.py to handle custom install commands for specific packages.
  • Updated check_requirements to execute custom install command according to the package index.

🎯 Purpose & Impact

  • 🎨 Streamlines the dependency check and installation process, making it more robust and maintainable.
  • πŸ“¦ Supports custom install commands for dependencies, allowing for more flexibility when installing specific packages like nvidia-tensorrt.
  • πŸš€ Potentially reduces errors and manual intervention when users set up their environment for exporting YOLOv5 models to TensorRT format, leading to a smoother user experience.

@glenn-jocher glenn-jocher self-assigned this Apr 22, 2022
@glenn-jocher glenn-jocher merged commit f62609e into master Apr 22, 2022
@glenn-jocher glenn-jocher deleted the update/check_requirements branch April 22, 2022 21:31
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant