Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update val.py #7478

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Update val.py #7478

merged 5 commits into from
Apr 19, 2022

Conversation

HERIUN
Copy link
Contributor

@HERIUN HERIUN commented Apr 19, 2022

is_coco doesn't work!! '/' -> os.sep!!

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved cross-platform path compatibility in validation script.

πŸ“Š Key Changes

  • Replaced a hardcoded path separator with os.sep for better cross-platform support.

🎯 Purpose & Impact

  • Purpose: The purpose is to ensure that the validation script works correctly on different operating systems by using the appropriate file path separator.
  • Impact: Users on operating systems with different path separators (like Windows and Unix-based systems) will experience consistent behavior when running validation on the COCO dataset. This change reduces path-related errors and enhances the platform-independence of the code. πŸš€

@glenn-jocher glenn-jocher merged commit d876caa into ultralytics:master Apr 19, 2022
@glenn-jocher
Copy link
Member

@HERIUN good fix! PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Update val.py

is_coco doesn't work!! '/' -> os.sep!!

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Cleanup

* fix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Update val.py

is_coco doesn't work!! '/' -> os.sep!!

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Cleanup

* fix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants