Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git_describe() #7402

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Update git_describe() #7402

merged 2 commits into from
Apr 12, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 12, 2022

Add .git path check to avoid fatal: not a git repository (or any of the parent directories): .git printout in #7401

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced git version description check for Ultralytics YOLOv5 repositories.

πŸ“Š Key Changes

  • Added an assertion to ensure the .git directory exists before running a git description command.

🎯 Purpose & Impact

  • Purpose: The update is intended to improve the reliability of the version description feature by verifying the presence of the .git directory.
  • Impact: This will prevent potential errors when attempting to get the git description on directories that are not git repositories. This change is particularly useful for debugging and version tracking, providing clearer information without causing unnecessary exceptions for users and developers alike. ✨

Add .git path check to avoid `fatal: not a git repository (or any of the parent directories): .git` printout
@glenn-jocher glenn-jocher self-assigned this Apr 12, 2022
@glenn-jocher glenn-jocher linked an issue Apr 12, 2022 that may be closed by this pull request
@glenn-jocher glenn-jocher merged commit 014acde into master Apr 12, 2022
@glenn-jocher glenn-jocher deleted the update/git branch April 12, 2022 15:26
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Update `git_describe()`

Add .git path check to avoid `fatal: not a git repository (or any of the parent directories): .git` printout

* Update general.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Running Example - Adding AutoShape...
1 participant