Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print dataset scan only if RANK in (-1, 0) #7337

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 7, 2022

Resolves multiple dataset scan printouts i.e. #7336 (comment)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved multi-GPU support in YOLOv5 training and dataset handling.

πŸ“Š Key Changes

  • Replaced list syntax with tuple syntax when checking RANK values.
  • Introduced LOCAL_RANK environment variable for better multi-GPU support.
  • Conditionally display cache information based on LOCAL_RANK in datasets.

🎯 Purpose & Impact

  • 🧩 Enhances compatibility with distributed computing, facilitating better support for multi-GPU training environments.
  • πŸš€ Potentially improves training experience on multi-GPU setups by preventing unnecessary output on all ranks except the master.
  • πŸ–₯️ Ensures that only the master process displays dataset scanning progress, reducing clutter and confusion in the console output when using multiple GPUs.

@glenn-jocher glenn-jocher self-assigned this Apr 7, 2022
@glenn-jocher
Copy link
Member Author

It works!!

Screen Shot 2022-04-07 at 4 37 56 PM

@glenn-jocher glenn-jocher merged commit 5f941a8 into master Apr 7, 2022
@glenn-jocher glenn-jocher deleted the update/DDP_dataset branch April 7, 2022 14:44
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Print dataset scan only `if RANK in (-1, 0)`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant