Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update export.py #7301

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Update export.py #7301

merged 2 commits into from
Apr 5, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 5, 2022

Simplify code.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement of the export script for model conversion compatibility.

πŸ“Š Key Changes

  • Removed commented out code that conditionally replaced activation functions with export-friendly versions.
  • Removed optional custom forward method assignment for the Detect module in export mode.

🎯 Purpose & Impact

  • 🧹 Cleans up the codebase by removing unnecessary commented code, leading to better maintainability.
  • πŸ‘¨β€πŸ’» Simplifies the export process by no longer needing to check for custom activation functions or forward methods in the Detect module.
  • πŸš€ Users can expect a more streamlined export script, possibly reducing issues during model conversion to formats like ONNX for deployment.

Simplify code.
@glenn-jocher glenn-jocher self-assigned this Apr 5, 2022
@glenn-jocher glenn-jocher merged commit d257c75 into master Apr 5, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch April 5, 2022 19:21
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Update export.py

Simplify code.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant