Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable usage of root logger #7296

Merged
merged 7 commits into from
Apr 5, 2022
Merged

fix: disable usage of root logger #7296

merged 7 commits into from
Apr 5, 2022

Commits on Apr 5, 2022

  1. fix: disable usage of root logger 

    `logging.basicConfig` configures Python's root logger. This prohibits
fine control of logging, overwrites logging configuration done outside
the package, and is not best practice. Instead, the used logger is now
configured directly, and the root logger is untouched.

Example:
    If yolov5 is used as part of another project with some sophisticated
    logging, the internal `logging.basicConfig` call overwrites all the
    external configuration.
    Maximilian Strobel authored and Maximilian Strobel committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    41321fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bug/global-logging

    @glenn-jocher
    glenn-jocher committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f36e347 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    3a5546e View commit details
    Browse the repository at this point in the history

  4. Update general.py

    @glenn-jocher
    glenn-jocher committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    665bf32 View commit details
    Browse the repository at this point in the history

  5. Update general.py

    @glenn-jocher
    glenn-jocher committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d4e93b1 View commit details
    Browse the repository at this point in the history

  6. Comment kaggle

    @glenn-jocher
    glenn-jocher committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a5f8969 View commit details
    Browse the repository at this point in the history

  7. Uncomment kaggle

    @glenn-jocher
    glenn-jocher committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    7f31712 View commit details
    Browse the repository at this point in the history