Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModuleAttributeError in DP and DDP mode #683

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

NanoCode012
Copy link
Contributor

@NanoCode012 NanoCode012 commented Aug 9, 2020

Fixes #682 .

I just made this quick PR to save you time. If you plan to change it somehow else, I can close this PR.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Relocation of image size verification in YOLOv5 training script for enhanced code structure.

📊 Key Changes

  • Relocated image size verification code to an earlier position in the training script.
  • Ensured image size verification occurs immediately after loading a pre-trained model and before initializing distributed training setup.

🎯 Purpose & Impact

  • Refinement of code flow: The verification of image size now happens shortly after any pre-existing model parameters are loaded. This tweak improves the logical flow of operations.
  • Potential decrease in bugs or errors: By checking image sizes earlier in the process, issues related to non-conforming image sizes can be caught sooner, possibly reducing errors during training setup.
  • No direct impact on model performance: This adjustment is for code quality and does not inherently change model training or performance, meaning users should see no difference in the behavior of their trained models.

@glenn-jocher glenn-jocher merged commit 3d8ed0a into ultralytics:master Aug 9, 2020
@NanoCode012 NanoCode012 deleted the attrib-fix branch August 9, 2020 18:03
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch.nn.modules.module.ModuleAttributeError in DP and DDP mode
2 participants