Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NCOLS from tqdm #5804

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Remove NCOLS from tqdm #5804

merged 2 commits into from
Nov 26, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 26, 2021

Fix attempt for #5797

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Removed the NCOLS constant from several progress bar initializations in training and validation scripts.

πŸ“Š Key Changes

  • The NCOLS variable, which controlled the column width of progress bars, has been removed from progress bar calls in train.py and val.py.
  • In utils/general.py, the comment related to NCOLS was updated to specify it's for tqdm's window size.

🎯 Purpose & Impact

  • The intent is likely to simplify the code by removing an unnecessary variable, thus reducing the complexity of configuration for the progress bars.
  • Users will not experience any visible change in functionality; however, the code will be cleaner and slightly more maintainable for developers.

@glenn-jocher glenn-jocher linked an issue Nov 26, 2021 that may be closed by this pull request
2 tasks
@glenn-jocher glenn-jocher merged commit 7c6bae0 into master Nov 26, 2021
@glenn-jocher glenn-jocher deleted the update/ncols branch November 26, 2021 12:37
@glenn-jocher glenn-jocher mentioned this pull request Nov 26, 2021
2 tasks
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Remove NCOLS from tqdm

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print bug?
1 participant