Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plots.py robustness #5616

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Improve plots.py robustness #5616

merged 2 commits into from
Nov 11, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 11, 2021

Addresses issues #5374, #5395, #5611

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancements to the font handling and label plotting in yolov5 utils.

πŸ“Š Key Changes

  • Introduced a try-except block for font loading to handle potential TypeError.
  • Added Timeout decorator to plot_labels function to prevent hanging issues.
  • Wrapped plot_labels with a try_except decorator for improved error handling.

🎯 Purpose & Impact

  • πŸ› οΈ The try-except block around font loading ensures compatibility with the latest Pillow library versions, preventing crashes due to font-related issues.
  • ⏱️ The Timeout decorator can prevent long or indefinite runtimes in the plot_labels function, leading to better resource management.
  • πŸ› The try_except decorator aims to make the code more robust by handling errors gracefully during the label plotting process.

The changes should enhance user experience by improving the stability and reliability of the visualization tools in the yolov5 repository.

@glenn-jocher glenn-jocher merged commit def7a0f into master Nov 11, 2021
@glenn-jocher glenn-jocher deleted the update/plots branch November 11, 2021 11:56
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Improve plots.py robustness

Addresses issues ultralytics#5374, ultralytics#5395, ultralytics#5611

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant