Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save_one_box() #5545

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Fix save_one_box() #5545

merged 2 commits into from
Nov 6, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 6, 2021

Fix for python detect.py --save-crop bug in #5544

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Centralized image cropping functionality to enhance code organization and flexibility.

πŸ“Š Key Changes

  • The save_one_box method, responsible for image cropping, was moved from utils/general.py to utils/plots.py.
  • Redundant imports related to this method were cleaned up across affected modules.

🎯 Purpose & Impact

  • Purpose: To consolidate image processing functions in a more appropriate module (utils/plots.py), thereby improving code maintainability.
  • Impact: No direct impact on end-user functionality; however, developers will now find image cropping-related code in the utils/plots.py file, which may slightly streamline the development process. πŸ‘¨β€πŸ’»πŸ“ˆ

@glenn-jocher glenn-jocher self-assigned this Nov 6, 2021
@glenn-jocher glenn-jocher merged commit 3f64ad1 into master Nov 6, 2021
@glenn-jocher glenn-jocher deleted the fix/save_one_box branch November 6, 2021 18:28
@glenn-jocher glenn-jocher mentioned this pull request Nov 6, 2021
2 tasks
@glenn-jocher glenn-jocher linked an issue Nov 6, 2021 that may be closed by this pull request
2 tasks
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Fix `save_one_box()`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect.py --save-crop bug
1 participant