Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update torch_utils.py import LOGGER" #5485

Closed
wants to merge 4 commits into from

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 3, 2021

Reverts #5483 to attempt CI failure fix.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced model export compatibility and internal logging refinement.

πŸ“Š Key Changes

  • Added Keras version specification (keras==2.6.0) to the model export dependencies.
  • Corrected the new line issue at the end of tutorial.ipynb.
  • Moved the LOGGER definition directly into utils/torch_utils.py.

🎯 Purpose & Impact

  • Keras version pinning ensures consistency and compatibility when exporting models, preventing issues with future Keras updates.πŸ”’
  • New line fix in the Jupyter notebook doesn't impact functionality but adheres to file format best practices. πŸ“
  • LOGGER relocation makes logging within torch_utils.py more self-contained and could improve module independence and readability. 🧾

Overall, these changes are poised to enhance the developer experience and the stability of model export features for end users.

@glenn-jocher glenn-jocher deleted the revert-5483-update/torch_utils_LOGGER branch November 3, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant