Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshgrid indexing='ij' for PyTorch 1.10 #5309

Merged
merged 5 commits into from
Nov 1, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 23, 2021

Will not merge currently as breaks backwards compatibility.

EDIT: added if statement based on torch version to maintain torch>=0.7 compatibility.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improvement of version checking in YOLOv5 with backward compatibility handling.

📊 Key Changes

  • Added check_version function call in yolo.py for grid creation compatible with PyTorch versions >=1.10.0.
  • Enforced a strict version requirement for the albumentations library in augmentations.py.
  • Updated the check_version function in general.py to include an option to enforce hard version checks.

🎯 Purpose & Impact

  • Ensures YOLOv5 accommodates changes in PyTorch's meshgrid function, maintaining compatibility with different versions. 🔄
  • Prevents running YOLOv5 with incompatible versions of dependencies which could lead to unexpected errors, by enforcing hard version checks where necessary. 🔒
  • Users benefit from clear error messages when their environment does not meet the version requirements, improving the user experience and ease of troubleshooting. 🛠️

Will not merge currently as breaks backwards compatibility.
@glenn-jocher glenn-jocher self-assigned this Oct 23, 2021
@glenn-jocher
Copy link
Member Author

/rebase

Will not merge currently as breaks backwards compatibility.
@glenn-jocher glenn-jocher merged commit 8c326a1 into master Nov 1, 2021
@glenn-jocher glenn-jocher deleted the update/meshgrid_indexing branch November 1, 2021 13:33
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Meshgrid `indexing='ij'` for PyTorch 1.10

Will not merge currently as breaks backwards compatibility.

* Meshgrid `indexing='ij'` for PyTorch 1.10

Will not merge currently as breaks backwards compatibility.

* Add check_version hard argument

* Update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant