-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci-testing.yml #5151
Update ci-testing.yml #5151
Conversation
add testing to saved_model and tflite conversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Hello @YoniChechik, thank you for submitting a π PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- β Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- β Verify all Continuous Integration (CI) checks are passing.
- β Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
Currently this fix is failing due to this bug: #5147 |
Once #5153 is merged, the errors above will be eliminated. |
@YoniChechik thanks for the PR! That's too bad that the CI checks did not catch the TF model issue with the SPPF layer, but I think the existing CI should suffice since it actually builds a new TF and Keras model already with this line. yolov5/.github/workflows/ci-testing.yml Lines 80 to 81 in 26784af
I'm a little confused about why the CI checks didn't report an error here, but I think the source of the problem was that it was loading models from the latest release, which at the time was v5.0. Since tf.py builds models from a *.pt file's internal yaml rather than directly from a yaml, it was pulling the v5.0 models and building them, and everything worked correctly there already of course. So I think this PR may be unnecessary other than to evaluate full TFLite export. The reason we don't use TFLite export in the CI is that it is much slower than all the other tests, roughly doubling the CI check time when we earlier looked at this option. |
/rebase |
I understand. I've also figured this download v5 part while debugging. In this case I'll close this PR. |
One possible solution might be to load the trained model instead of the official model. The trained model is built from the --cfg *.yaml: # Export
python models/yolo.py --cfg ${{ matrix.model }}.yaml # build PyTorch model
python models/tf.py --weights runs/train/exp/weights/last.pt # build TensorFlow model
`` |
add testing to saved_model and tflite conversion
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Enhanced export compatibility for YOLOv5 models in TensorFlow formats.
π Key Changes
saved_model
andtflite
formats.π― Purpose & Impact